Skip to content

Trivia in tokens - #23276

Open
bit-aloo wants to merge 22 commits into
rust-lang:masterfrom
bit-aloo:2026-08-29-trivia-in-tokens
Open

Trivia in tokens#23276
bit-aloo wants to merge 22 commits into
rust-lang:masterfrom
bit-aloo:2026-08-29-trivia-in-tokens

Conversation

@bit-aloo

@bit-aloo bit-aloo commented Sep 1, 2026

Copy link
Copy Markdown
Member

TODO

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

+18,204 -23,157

😢

Isn't there a way to make this smaller? Some ideas:

  • Do not print [] [] for empty leading+trailing trivia.
  • Print leading/trailing trivia like before temporarily.

@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch 2 times, most recently from 20ae132 to 138f614 Compare September 11, 2026 08:06
@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from 26b762b to 612f015 Compare September 11, 2026 08:44
@bit-aloo
bit-aloo marked this pull request as ready for review September 11, 2026 09:24
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants