hir_typeck: suggest removing redundant .iter() calls#153700
Open
vishnupoddar12 wants to merge 1 commit intorust-lang:mainfrom
Open
hir_typeck: suggest removing redundant .iter() calls#153700vishnupoddar12 wants to merge 1 commit intorust-lang:mainfrom
vishnupoddar12 wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
vishnupoddar12
force-pushed
the
issue-153667-fix
branch
3 times, most recently
from
ab4ea7c to
6b03e95
Compare
This diagnostic intercepts cases where `.iter()` is called on a type that already implements `Iterator` Instead of confusing trait fallback suggestions, it explicitly guides the user to remove the `.iter()` call. It implements precise span computation to support `cargo fix` while carefully preserving all inline comments and horizontal whitespace during the AST string replacement.
vishnupoddar12
force-pushed
the
issue-153667-fix
branch
from
6b03e95 to
8f0debd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diagnostic intercepts cases where
.iter()is called on a type that already implementsIteratorInstead of confusing trait fallback suggestions, it explicitly guides the user to remove the
.iter()call. It implements precise span computation to supportcargo fixwhile carefully preserving all inline comments and horizontal whitespace during the AST string replacement.Fixes #153667