feat: add nightly minimum dependencies test#55
Merged
Conversation
jalil-salame
force-pushed
the
jalil/verify-minimum-dependencies
branch
from
c839da3 to
b6110cf
Compare
qwandor
approved these changes
Dec 16, 2024
Tim-Zhang
approved these changes
Dec 20, 2024
Contributor
Tim-Zhang
left a comment
Tim-Zhang
left a comment
There was a problem hiding this comment.
LGTM, thanks @jalil-salame
Contributor
@Tim-Zhang the release should be |
Contributor
Author
|
I'll do a small rework cause the tests no longer work here (tonic-conn feature was removed) |
jalil-salame
force-pushed
the
jalil/verify-minimum-dependencies
branch
2 times, most recently
from
a2930a9 to
28b5131
Compare
Add a nightly toolchain to test builds using the `-Z direct-minimum-dependencies` flag. This ensures our minimum version requirements are compatible with our source code. This required bumping some versions: - libc: `0.2.138` -> `0.2.158` as `vsock-rs` depends on `0.2.158`. - tokio: `1` -> `1.27` as we depend on methods/trait impls which are only available starting that version. This ensures our minimum `tonic` requirement still compiles. Signed-off-by: Jalil David Salamé Messina <jalil.salame@gmail.com>
jalil-salame
force-pushed
the
jalil/verify-minimum-dependencies
branch
from
28b5131 to
5fb60b9
Compare
Contributor
Author
|
I adjusted the branch rules, so that it now requires |
qwandor
approved these changes
Dec 20, 2024
Tim-Zhang
reviewed
Dec 20, 2024
Contributor
|
@jalil-salame I left a comment, PTAL, thanks. |
Tim-Zhang
added a commit
to Tim-Zhang/tokio-vsock
that referenced
this pull request
Dec 20, 2024
Bump the major version for API has changed in rust-vsock#54 and features removed in rust-vsock#56 Also this release includes rust-vsock#53 and rust-vsock#55 Signed-off-by: Tim Zhang <tim@hyper.sh>
Tim-Zhang
added a commit
to Tim-Zhang/tokio-vsock
that referenced
this pull request
Dec 20, 2024
Bump the major version for rust-vsock#54 which changed API and rust-vsock#56 which removed features. Also this release includes rust-vsock#53 and rust-vsock#55. Signed-off-by: Tim Zhang <tim@hyper.sh>
Merged
Tim-Zhang
added a commit
to Tim-Zhang/tokio-vsock
that referenced
this pull request
Dec 20, 2024
Bump the major version for rust-vsock#54 which changed API and rust-vsock#56 which removed features. Also this release includes rust-vsock#53 and rust-vsock#55. Signed-off-by: Tim Zhang <tim@hyper.sh>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a nightly toolchain to test builds using the
-Z direct-minimum-dependenciesflag. This ensures our minimum version requirements are compatible with our source code.This required bumping some versions:
0.2.138->0.2.158asvsock-rsdepends on0.2.158.1->1.27as we depend on methods/trait impls which are only available starting that version.1.34as tonic 0.12 requires tokio 1.34This ensures our minimum
tonicrequirement still compiles.This should be released as
0.6.1as requested by @cryo28 on #53