Add post-ad resume hardening with pause intent and retry#3
Open
Add post-ad resume hardening with pause intent and retry#3
Conversation
Owner
ryanbr
commented
Mar 22, 2026
ryanbr
commented
- Don't block player reloads when user has paused (only block pause/play toggle)
- Respect user's manual pause — don't auto-resume after ad reload
- Retry play() after 1.5s if initial resume didn't take effect
- Reduces cases where player stays paused after ads until manual click
- Don't block player reloads when user has paused (only block pause/play toggle) - Respect user's manual pause — don't auto-resume after ad reload - Retry play() after 1.5s if initial resume didn't take effect - Reduces cases where player stays paused after ads until manual click Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ryanbr
added a commit
that referenced
this pull request
Mar 24, 2026
Merged into vaft-testing-ublock-origin.js and video-swap-new-ublock-origin-testing.js: - Segment recovery cache (PR #1) - Post-ad resume hardening (PR #2) - Failed backup player tracking (PR #3, vaft only) - Ad-end grace period (PR #4) PR #3 and #4 merged: FailedBackupPlayerTypes.clear() placed inside the grace period check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Resume hardening coexists with muted restore and drift correction in the reload setTimeout. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.