Conversation
Addresses reviewer concerns on the stable release: 1. Reload after ad-end now also triggers when real segments were stripped (hadStrippedSegments), even within cooldown window. Fresh token/manifest cleans up player state more thoroughly than pause/play — reduces risk of ads leaking through when cooldown would have skipped the reload. 2. FailedBackupPlayerTypes changed from Set to Map<type, timestamp>. Failures expire after 15s so transient network issues (GQL errors, connection blips) don't blacklist a player type for the entire ad break. 3. README updates: document PinBackupPlayerType quality caveat (360p lock when autoplay gets pinned), ReloadCooldownSeconds, DisableReloadCap. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses reviewer concerns on the stable release:
Reload after ad-end now also triggers when real segments were stripped (hadStrippedSegments), even within cooldown window. Fresh token/manifest cleans up player state more thoroughly than pause/play — reduces risk of ads leaking through when cooldown would have skipped the reload.
FailedBackupPlayerTypes changed from Set to Map<type, timestamp>. Failures expire after 15s so transient network issues (GQL errors, connection blips) don't blacklist a player type for the entire ad break.
README updates: document PinBackupPlayerType quality caveat (360p lock when autoplay gets pinned), ReloadCooldownSeconds, DisableReloadCap.