feat: env-configurable plugin loading and home-manager plugin settings#623
Open
connor-grady wants to merge 3 commits into
Open
feat: env-configurable plugin loading and home-manager plugin settings#623connor-grady wants to merge 3 commits into
connor-grady wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProxyConfig.pluginDirandpluginConfigPathwere only settable through the embeddedcreateProxyServerAPI — the CLI never read them, so a standalonemeridianprocess always used the fixed~/.config/meridian/plugins/and~/.config/meridian/plugins.json.bin/cli.tsnow readsMERIDIAN_PLUGIN_DIRandMERIDIAN_PLUGIN_CONFIGand forwards them intostartProxyServer(documented in--help), so both paths are configurable for the standalone proxy.The home-manager module gains two settings.
services.meridian.settings.pluginConfigtakes a list of{ path, enabled }submodules and renders them, in order, to aplugins.jsonmanifest in the Nix store (viapkgs.formats.json), passed asMERIDIAN_PLUGIN_CONFIG.services.meridian.settings.pluginDirmaps toMERIDIAN_PLUGIN_DIR. The serviceEnvironmentnow derives eachMERIDIAN_*variable name automatically from itssettingsattribute path, so new settings are exported without a hand-maintained key mapping.