docs(input): add fieldset + label example without a legend#4606
Open
JamBalaya56562 wants to merge 1 commit into
Open
docs(input): add fieldset + label example without a legend#4606JamBalaya56562 wants to merge 1 commit into
JamBalaya56562 wants to merge 1 commit into
Conversation
The input docs only showed a fieldset grouping example that uses a `fieldset-legend`. Add a simpler `fieldset` + `label` example (no legend) that mirrors the form-control replacement shown in the upgrade guide, using `for`/`id` to associate the label with the input. closes saadeghi#3573 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
JamBalaya56562
force-pushed
the
docs-input-fieldset-label-example
branch
from
9bbe86d to
8ce518e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #3573
Adds a simple
fieldset+labelgrouping example (without afieldset-legend) to the Text Input docs page, right after the existing "With fieldset and fieldset-legend" example.Why
In #3573 the reporter pointed out that the input docs only demonstrate grouping with a
fieldset-legend, and there was no simplefieldset+labelexample matching the form-control replacement in the upgrade guide. This adds exactly that, usingfor/idto associate the label with the input.The issue's other concern — the overlap between
fieldset-labelandlabel— has since been resolved:fieldset-labelis now marked deprecated in favor oflabelinfieldset.css(kept only to avoid a breaking change) and no longer appears in any docs example. So this PR only addresses the remaining, still-missing example.Notes
$$-prefixed code block).