docs: add sanitized demo plan#144
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d815c73f10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --fail-under=90 \ | ||
| --include "src/**/*.ts" "src/**/*.tsx" \ | ||
| --exclude "src/**/*.test.ts" "src/**/*.test.tsx" "src/**/*.spec.ts" "src/**/*.spec.tsx" | ||
| --exclude "*.test.ts" "*.test.tsx" "*.spec.ts" "*.spec.tsx" "*/src/test/*" |
There was a problem hiding this comment.
Use a repo-relative src/test exclude
For PRs that touch root-level test helpers such as this commit's src/test/e2eTauriMock.ts, this pattern does not exclude them: diff-cover documents --exclude as fnmatch patterns that should be relative to the current git directory, so */src/test/* only matches paths with a directory before src, not src/test/.... Because the include glob above still admits src/**/*.ts, those mock-helper changes can be counted against the 90% diff-coverage gate instead of being excluded as intended; use a repo-relative pattern like src/test/* or src/test/**.
Useful? React with 👍 / 👎.
What
Northstar Labstenant..exampledomains, fake personas, andNSD-*ticket IDs.vitestand@vitest/coverage-v8together to clear GHSA-5xrq-8626-4rwp and keep coverage compatible with Vitest 4.Why
vitest <4.1.0advisory; an older Dependabot PR only bumpedvitest, leaving coverage on 3.x and causing coverage failures.How
docs/demo/sanitized-demo-plan.mdwith safe/unsafe source boundaries, a scripted fake support ticket, cleanup items, and verification commands.northstar.exampleequivalents.vitestand@vitest/coverage-v8as a matched pair.Testing
git diff --checkrgsanitizer sweeps for stale company/person/demo residuesgitleaks detect --source . --redact --no-gitnode scripts/ci/check-workstation-preflight.mjsnode scripts/ci/check-workflow-command-drift.mjsnode scripts/ci/check-version-parity.mjspnpm audit --audit-level highpnpm ui:gate:staticpnpm exec vitest run src/features/workspace/WorkspaceHeroLayout.test.tsx src/components/Settings/SettingsTab.test.tsxpnpm test:coverageHEADafter API publication.pnpm peers checkreports an existing@commitlint/cz-commitlint/inquirerpeer mismatch unrelated to this Vitest fix.Performance impact
Risk / Notes
git pushis blocked in the current Codex environment by approval policy.HEAD.Screenshots (UI only)
docs/screenshots/renders/.Lockfile rationale (if lockfile changed)
pnpm-lock.yamlchanged to upgradevitestand@vitest/coverage-v8together to 4.1.8, clearing the critical Vitest advisory while preserving coverage compatibility.