Conversation
github-actions
Bot
added
documentation
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for HashiCorp Nomad as a new provider for Sablier, enabling dynamic scaling of Nomad job task groups from 0 to N allocations on demand.
Key changes:
- Implements the Nomad provider with full support for job lifecycle management (start, stop, inspect, list, groups)
- Adds event stream monitoring for real-time allocation status updates
- Includes comprehensive test coverage using testcontainers
Reviewed Changes
Copilot reviewed 20 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/sabliercmd/provider.go | Adds Nomad provider initialization and configuration setup |
| pkg/provider/nomad/*.go | Core provider implementation including job operations and event handling |
| pkg/provider/nomad/*_test.go | Comprehensive test suite with testcontainers integration |
| pkg/config/provider.go | Adds Nomad configuration structure with ACL, namespace, and region support |
| go.mod/go.sum | Adds Nomad API and related dependencies |
| docs/providers/nomad.md | Complete documentation for Nomad provider usage |
| README.md | Updates provider list to include Nomad |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| // Determine status | ||
| if desiredCount == 0 { | ||
| return sablier.NotReadyInstanceState(instanceName, runningCount, p.desiredReplicas), nil |
There was a problem hiding this comment.
When desiredCount is 0, the third parameter should be desiredCount instead of p.desiredReplicas to maintain consistency with line 92 and properly reflect the actual desired state. The DesiredReplicas field in InstanceInfo should represent the target count from the job spec (which is 0), not the provider's default desired replicas (which is 1).
Suggested change
| return sablier.NotReadyInstanceState(instanceName, runningCount, p.desiredReplicas), nil | |
| return sablier.NotReadyInstanceState(instanceName, runningCount, desiredCount), nil |
❌ 12 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 12 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #217