Skip to content

fix(data-grid): preserve onRowSelectionChange tanstack feature #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadmann7 merged 1 commit into from
Feb 17, 2026
+3 −1
Merged

fix(data-grid): preserve onRowSelectionChange tanstack feature #1110

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/hooks/use-data-grid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1932,8 +1932,10 @@ function useDataGrid<TData>({
store.setState("focusedCell", null);
store.setState("editingCell", null);
});

propsRef.current.onRowSelectionChange?.(updater);
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onRowSelectionChange here calls the user prop with updater, but the surrounding handlers (onSortingChange / onColumnFiltersChange) pass the resolved next state value. Since this function already computes newRowSelection, consider invoking propsRef.current.onRowSelectionChange with newRowSelection to match the established pattern and avoid parent state updates diverging if the parent applies a functional updater against a different previous selection state.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a new external behavior (calling propsRef.current.onRowSelectionChange from the internal handler) but there isn't a corresponding test (unlike sorting/filtering callbacks). Add a unit test that triggers a row selection change and asserts the callback is called with the expected argument shape/value so regressions are caught.

Suggested change
propsRef.current.onRowSelectionChange?.(updater);
propsRef.current.onRowSelectionChange?.(newRowSelection);

Copilot uses AI. Check for mistakes.
},
[store, columnIds],
[store, columnIds, propsRef],
);

const onRowSelect = React.useCallback(
Expand Down