fix: cursor jumps to the end when editing in the middle#1112
Open
MdTehseenKhan wants to merge 1 commit intosadmann7:mainfrom
Open
Conversation
…rlCell - Introduced a ref to track previous editing state to ensure focus is only applied when entering edit mode. - Updated React useEffect logic to prevent unnecessary focus calls when already in editing mode.
|
@MdTehseenKhan is attempting to deploy a commit to the sadmann7 Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Cursor jumps to the end when editing in the middle
This PR fixes cursor jumping to the end when editing in the middle of
ShortTextCellandUrlCell. The focus/selection effect now runs only when entering edit mode (isEditing && !wasEditing) using aprevIsEditingRef, instead of on everyvaluechange, so the caret stays in place while typing.Related Issue: [bug]: Cursor jumps to the end when editing in the middle
Additional Information
TableCN_Fixed.mp4