fix(protocol-kit): Fix signature generation for multiple contract signatures#1114
Open
sidnym-ladrut wants to merge 1 commit intosafe-global:mainfrom
Open
fix(protocol-kit): Fix signature generation for multiple contract signatures#1114sidnym-ladrut wants to merge 1 commit intosafe-global:mainfrom
sidnym-ladrut wants to merge 1 commit intosafe-global:mainfrom
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Bullet1010
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it solves
There are currently a few minor issues in
protocol-kitrelated to contract signatures (i.e. EIP-1271):Safe.ts).How this PR fixes it
These issues are fixed in the following ways:
CONTRACT_SIGNATUREresponses are registered as contract signatures.