Skip to content

fix(protocol-kit): Fix signature generation for multiple contract signatures#1114

Open
sidnym-ladrut wants to merge 1 commit intosafe-global:mainfrom
sidnym-ladrut:sl/fix-protocol-kit-eip1271
Open

fix(protocol-kit): Fix signature generation for multiple contract signatures#1114
sidnym-ladrut wants to merge 1 commit intosafe-global:mainfrom
sidnym-ladrut:sl/fix-protocol-kit-eip1271

Conversation

@sidnym-ladrut
Copy link

What it solves

There are currently a few minor issues in protocol-kit related to contract signatures (i.e. EIP-1271):

  1. Contract signatures processed by the API are not recognized as such (fix in Safe.ts).
  2. The dynamic part of a contract signature is calculated as the entire segment of the given data, when it should be the last 97 bytes only (65 bytes signature + 32 bytes length).

How this PR fixes it

These issues are fixed in the following ways:

  1. All CONTRACT_SIGNATURE responses are registered as contract signatures.
  2. The dynamic part of contract signatures is adjusted to be the last 97 bytes of the data payload.

@github-actions
Copy link

github-actions bot commented Jan 29, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sidnym-ladrut
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants