Enforce Claude graph lookup before raw search#626
Enforce Claude graph lookup before raw search#626robertmonka wants to merge 2 commits intosafishamsi:v5from
Conversation
|
Hi, The embedded guard script detects graph usage and excludes graphify-out/.claude paths using hard-coded POSIX separators, which fails on Windows-style backslash paths and causes incorrect blocking/allowing behavior. This breaks the guard for the repo’s Windows Claude platform. Severity: action required | Category: correctness How to fix: Normalize guard path separators Agent prompt to fix - you can give this to your LLM of choice:
We noticed a couple of other issues in this PR as well - happy to share if helpful. Spotted by Qodo code review - free for open-source projects. |
db4c844 to
6c28d76
Compare
6c28d76 to
4b7d0ac
Compare
|
Thanks for the review! I pushed an update addressing the Windows path separator issue in the Claude guard, rebased the branch onto the current v5, and the latest PR checks show no failing checks. Could you please take another look and merge if it looks good? |
|
Quick correction: please hold off on merging for now. I saw the refreshed CI failures after the rebase and am fixing them before asking for another review. |
|
The requested Qodo fix is now addressed: the Claude guard normalizes Windows-style backslash paths before checking graphify-out and .claude paths, with regression tests added. I also fixed the refreshed CI failures after rebasing onto v5.\n\nVerification:\n- Local full test suite: 471 passed\n- GitHub Actions: test (3.10), test (3.11), test (3.12), and test (3.13) are all passing\n- PR is mergeable\n\nThis is ready to merge when you have a chance. |
Summary
Tests