Fix ambiguous cross-file call inference for duplicate helper names#632
Open
alceops wants to merge 1 commit intosafishamsi:v5from
Open
Fix ambiguous cross-file call inference for duplicate helper names#632alceops wants to merge 1 commit intosafishamsi:v5from
alceops wants to merge 1 commit intosafishamsi:v5from
Conversation
safishamsi
added a commit
that referenced
this pull request
May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #543.
This keeps cross-file
callsinference from guessing when an unqualified callee label resolves to multiple functions across the corpus. Today the global label map stores one node per normalized label, so common helper names likelog(),execute(), ormain()can resolve to whichever duplicate was seen last, creating falseINFERREDcalls and inflating graph metrics such asgod_nodes.Changes:
log()helpers provingrun() -> log()is not guessed when ambiguousVerification:
python3 -m py_compile graphify/extract.py tests/test_extract.pypip install -e . pytestpytest tests/test_extract.py -q→ 21 passedgraphify update .