Skip to content

status bar isHidden not right in viewWillAppear #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandyway wants to merge 11 commits into
base: master
Choose a base branch
from
Open

status bar isHidden not right in viewWillAppear #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ca66f26
status bar isHidden not right in viewWillAppear
sandyway Jan 23, 2017
be8bb1d
postrollVC shouldn't pop when exit playing movie not finished
sandyway Feb 5, 2017
87402b8
remove share button
sandyway Feb 5, 2017
3f9aba3
recover share button
sandyway Feb 5, 2017
8eedbd1
make slider' touchable area larger.hide status bar when viewDidAppear
sandyway Feb 9, 2017
040e133
add dlna
sandyway Jun 15, 2017
8ae91fe
Merge branch 'master' of https://github.com/mobileplayer/mobileplayer…
biggerthan Jun 26, 2018
45fc925
升级到swift 4.2
biggerthan Jun 28, 2018
6833082
添加dismiss事件, 适配iphoneX
biggerthan Jun 28, 2018
ca82106
Merge branch 'originalFix'
biggerthan Jun 28, 2018
e1d1d7c
swift 4.2
biggerthan Jun 28, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .swift-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0
4.2
25 changes: 15 additions & 10 deletions MobilePlayer.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,7 @@
};
5F56CB801C040E8D00EF50C4 = {
CreatedOnToolsVersion = 7.1.1;
DevelopmentTeam = 8VBY4GCZ7Q;
LastSwiftMigration = 0800;
};
5F56CB951C040E8E00EF50C4 = {
Expand Down Expand Up @@ -905,7 +906,7 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
};
name = Debug;
};
Expand All @@ -925,7 +926,7 @@
PRODUCT_BUNDLE_IDENTIFIER = com.movielala.MobilePlayerExampleStores;
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
};
name = Release;
};
Expand All @@ -935,12 +936,13 @@
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
DEBUG_INFORMATION_FORMAT = dwarf;
DEVELOPMENT_TEAM = 8VBY4GCZ7Q;
INFOPLIST_FILE = MobilePlayerExamples/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.1;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.movielala.MobilePlayerExamples;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
};
name = Debug;
};
Expand All @@ -950,12 +952,13 @@
ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES;
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon;
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
DEVELOPMENT_TEAM = 8VBY4GCZ7Q;
INFOPLIST_FILE = MobilePlayerExamples/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 9.1;
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.movielala.MobilePlayerExamples;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
};
name = Release;
};
Expand All @@ -968,7 +971,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.mobileplayer.MobilePlayerExamplesUITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
TEST_TARGET_NAME = MobilePlayerExamples;
USES_XCTRUNNER = YES;
};
Expand All @@ -983,7 +986,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = com.mobileplayer.MobilePlayerExamplesUITests;
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
TEST_TARGET_NAME = MobilePlayerExamples;
USES_XCTRUNNER = YES;
};
Expand Down Expand Up @@ -1034,7 +1037,7 @@
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
TARGETED_DEVICE_FAMILY = "1,2";
VERSIONING_SYSTEM = "apple-generic";
VERSION_INFO_PREFIX = "";
Expand Down Expand Up @@ -1078,7 +1081,7 @@
MTL_ENABLE_DEBUG_INFO = NO;
SDKROOT = iphoneos;
SWIFT_OPTIMIZATION_LEVEL = "-Owholemodule";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
TARGETED_DEVICE_FAMILY = "1,2";
VALIDATE_PRODUCT = YES;
VERSIONING_SYSTEM = "apple-generic";
Expand All @@ -1102,7 +1105,7 @@
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_OPTIMIZATION_LEVEL = "-Onone";
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
};
name = Debug;
};
Expand All @@ -1121,7 +1124,7 @@
PRODUCT_BUNDLE_IDENTIFIER = "com.movielala.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
SKIP_INSTALL = YES;
SWIFT_VERSION = 3.0;
SWIFT_VERSION = 4.2;
};
name = Release;
};
Expand All @@ -1142,6 +1145,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "com.movielala.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 4.2;
};
name = Debug;
};
Expand All @@ -1159,6 +1163,7 @@
LD_RUNPATH_SEARCH_PATHS = "$(inherited) @executable_path/Frameworks @loader_path/Frameworks";
PRODUCT_BUNDLE_IDENTIFIER = "com.movielala.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
SWIFT_VERSION = 4.2;
};
name = Release;
};
Expand Down
2 changes: 2 additions & 0 deletions MobilePlayer/Config/ElementConfig.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ public enum ElementType: String {

/// Element is a slider.
case Slider = "slider"

case VolumeView = "volumeView"
}

/// Determines how an element's width will be calculated.
Expand Down
2 changes: 1 addition & 1 deletion MobilePlayer/Extensions/ClosureSupport.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ extension Timer {
extension UIControl {

@discardableResult
func addCallback(callback: @escaping () -> Void, forControlEvents controlEvents: UIControlEvents) -> UnsafeMutableRawPointer {
func addCallback(callback: @escaping () -> Void, forControlEvents controlEvents: UIControl.Event) -> UnsafeMutableRawPointer {
let callbackContainer = CallbackContainer(callback: callback)
let key = Unmanaged.passUnretained(callbackContainer).toOpaque()
objc_setAssociatedObject(self, key, callbackContainer, objc_AssociationPolicy.OBJC_ASSOCIATION_RETAIN_NONATOMIC)
Expand Down
Loading