Open
Conversation
Migration to AVKit
Contributor
|
Thanks for the PR! Could you convert the indentation length back to two spaces in all files so I can also take an easier look at the diff? Would also appreciate a Travis CI config update. |
|
@ferhatabd @isair This is great thanks guys MobilePlayer is a fantastic module - would love to be able to continue using it |
|
Any update? Doesn't work on ios13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration to AVKit
Set the iOS target to iOS10 - therefore not backwards compatible but might be helpful for new comers.
Cheers
This change is