feat(matcher): add per-test filtering via testsFilter and SA11Y_AUTO_FILTER_TESTS#984
Open
jethrolarson wants to merge 2 commits into
Open
feat(matcher): add per-test filtering via testsFilter and SA11Y_AUTO_FILTER_TESTS#984jethrolarson wants to merge 2 commits into
jethrolarson wants to merge 2 commits into
Conversation
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Jethro Larson <j***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
…FILTER_TESTS Implements the long-standing TODO for per-test exclusion from automatic accessibility checks. Adds: - `testsFilter` field to `AutoCheckOpts` — array of test name substrings - `skipTestByName()` exported utility, mirroring `skipTest()` for files - `SA11Y_AUTO_FILTER_TESTS` env var for pipeline-level test name exclusions - `updateAutoCheckOpts` reads the env var and merges into `testsFilter` Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2f2648d to
e0aeaf2
Compare
|
Thanks for the contribution! Before we can merge this, we need @jethrolarson to sign the Salesforce Inc. Contributor License Agreement. |
vanshika-sharmaSFDC
approved these changes
Jun 17, 2026
Author
|
please merge or ask for changes 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human Note: Really I'd prefer to be able to disable sa11y for a specific test in-line but there was a TODO to implement it this way so claude and I took that path. 🙏
Summary
Implements the long-standing TODO in
AutoCheckOptsfor per-test exclusion from automatic accessibility checks:testsFilter?: string[]toAutoCheckOpts— array of test name substrings; matched case-insensitively, same asfilesFilterskipTestByName()exported utility, mirroring the existingskipTest()for file pathsSA11Y_AUTO_FILTER_TESTSenv var so pipeline-level configs can exclude specific tests without code changesupdateAutoCheckOptsreads the env var and merges intotestsFilterMotivation
When
runAfterEachis enabled at the pipeline level across many teams, there is currently no way to exempt a single test without either skipping the entire test or filtering the whole file. This fills that gap.Usage
Programmatic:
Via env var (pipeline/CI):
SA11Y_AUTO_FILTER_TESTS="my test that has a known violation,another test name" jestTest plan
skipTestByNameunit tests (parametrized, 7 cases) passtestsFilterinrunAutomaticCheckpassdefaultAutoCheckOptssnapshot updated to includetestsFilter: []automaticMatcher.test.tspass🤖 Generated with Claude Code