Review Section 5.1.2. Canonicalized Host Names#569
Draft
colincasey wants to merge 4 commits into
Draft
Conversation
… 5.1.2 Extract the pure RFC 6265 Section 5.1.2 algorithm into a new canonicalizedHostName module with a labelToASCII helper for per-label IDNA conversion. canonicalDomain retains library-specific pre-processing (trimming, leading-dot removal, IPv6 handling) and delegates to the new function for the RFC steps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
canonicalDomain.tsto map step-by-step to RFC 6265 Section 5.1.2canonicalizedHostName.tscontaining the pure RFC algorithm (steps 1-3) separate from library-specific pre-processinglabelToASCIIhelper for per-label IDNA conversion via the URL constructor's built-in UTS#46Future work
Sub-issues created under #512 for follow-up refactoring discovered during this review:
Test plan
api-extractorclean)attwgreen)Closes #512