This repository was archived by the owner on Jun 27, 2020. It is now read-only.
Fix editusertext action#50
Open
siegy22 wants to merge 1 commit intosamsymons:masterfrom
siegy22:master
Open
Conversation
I was experiencing strange behaviour of Client::Miscellaneous#edit method, because it somehow rendered the page (as HTML) when I wanted to edit a comment. However the comment was edited, the problem was, that the response was a HTML DOM, which then raised a rate limit error because somewhere in that DOM there was "RATELIMIT" written and that matched in Error#from_status_code_and_body. So I added the api_type key and it worked fine. Plus I added a little guard to verify that `options` is a hash. When I first used the edit function I just passed the text as the second parameter, which then gave me a silly error that string cannot be converted into Integer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was experiencing strange behaviour of Client::Miscellaneous#edit
method, because it somehow rendered the page (as HTML) when I wanted
to edit a comment.
However the comment was edited, the problem was, that the response was a HTML
DOM, which then raised a rate limit error because somewhere in that
DOM there was "RATELIMIT" written and that matched in
Error#from_status_code_and_body.
So I added the api_type key and it worked fine.
Plus I added a little guard to verify that
optionsis a hash.When I first used the edit function I just passed the text as the
second parameter, which then gave me a silly error that string cannot be converted into Integer.