move type identifiers from type representatives to members#38
Merged
davidchambers merged 1 commit intomasterfrom Nov 3, 2019
Merged
move type identifiers from type representatives to members#38davidchambers merged 1 commit intomasterfrom
davidchambers merged 1 commit intomasterfrom
Conversation
Avaq
approved these changes
May 10, 2019
Member
Avaq
left a comment
Avaq
left a comment
There was a problem hiding this comment.
I think we can move forward with this. I will address my concerns about adoption once they come up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This specification currently reuses the type representatives defined in the Fantasy Land specification. In fantasyland/fantasy-land#315 I have proposed changing the property name from
'constructor'to'fantasy-land'. The proposal is likely to be accepted, at which point members of algebraic data types would need two different “type representatives” to be compatible with both specifications.A type identifier need not be defined on a type representative; attaching it to each member would work equally well. This pull request removes all references to type representatives, disentangling this specification from the Fantasy Land specification.