everything by davidchambers · Pull Request #1 · sanctuary-js/silly-goat

davidchambers · 2017-02-18T16:19:00Z

TODO:

add circle.yml
update server (and circle.yml) to Node 6
add Ramda
expose console (so one can use console.log in snippets)
integrate xyz (dependent on respect --publish-command for private packages davidchambers/xyz#37)

davidchambers · 2017-02-18T16:21:59Z

bin/hubot

+#!/usr/bin/env bash
+set -e
+
+PATH="node_modules/.bin:node_modules/hubot/node_modules/.bin:$PATH" \


This is from the automatically generated boilerplate. Is it required? If not, let's remove it.

svozza · 2017-02-18T16:21:01Z

Makefile

@@ -0,0 +1,14 @@
+ESLINT = node_modules/.bin/eslint --config node_modules/sanctuary-style/eslint-es3.json --env es3 --env node
+NPM = npm


For now, yes. :)

svozza · 2017-02-18T16:22:47Z

package.json

+    "sanctuary-type-classes": "*"
+  },
+  "devDependencies": {
+    "eslint": "2.9.x",


This is a very old version of Eslint.

It is. The reason I'm specifying an old version is that sanctuary-style@0.4.x does not make use of any rules added since eslint@2.9.x. We should update sanctuary-style to the latest version of ESLint then update both dependencies at once (here and in other projects).

Sounds good.

Bradcomp · 2017-02-18T16:27:39Z

package.json

+  "version": "0.0.0",
+  "private": true,
+  "author": "David Chambers <dc@davidchambers.me>",
+  "description": "A simple helpful robot for your Company",


Is this description from the boilerplate?

Yes, it was. ⚡

Bradcomp · 2017-02-18T16:30:09Z

circle.yml

+
+machine:
+  node:
+    version: 4


Out of curiosity, why Node 4 instead of 6 or 7?

No good reason. Node 4 came installed on Ubuntu. For a small project it doesn't matter much to me which Node version we use so I'm happy to stick with the default.

Gotcha. In the case of a bot it might be worth it to consider updating. It would allow us to use the full set of ES6 features in the code we write.

Excellent point! I had not considered that. I'll install Node 6 on the server. :)

Where is the server? It would be nice to do it with infrastructure as code, maybe use a Docker container so its configuration would be in source control.

Where is the server?

On Linode currently.

It would be nice to do it with infrastructure as code, maybe use a Docker container so its configuration would be in source control.

Sounds great! This needn't happen as part of this initial pull request though. ;)

Fair enough. My preference is to always put code into production with provisioning scripts. Retrofitting is always harder.

davidchambers · 2017-02-19T15:19:01Z

Dockerfile

+
+COPY . .
+
+ENTRYPOINT ["dumb-init", "bin/hubot"]


Could you review this, @svozza? I'm quite new to Docker. I followed some of these suggestions.

That's a really good article. I like the trick about caching the node_modules layer. LGTM.

Btw, if you want to set Hubot to listen on a specific port you can do ENV PORT 3000. Then when running your container you do the port mapping with the -p option on docker run.

Also, is it possible to make CircleCI build and push new image to DockerHub whenever there's a successful merge to master?

Btw, if you want to set Hubot to listen on a specific port you can do ENV PORT 3000.

Does Hubot listen? My understanding is that it makes a request to the Gitter streaming API and consumes the response indefinitely.

Also, is it possible to make CircleCI build and push new image to DockerHub whenever there's a successful merge to master?

Would it also be possible to automatically update the Linode in response to this push? If not it seems reasonable to me to publish to Docker Hub via xyz, then pull and restart the bot on the Linode manually.

Yeah, looking at the docs Linode really doesn't seem set up for CD, if it was something like Elastic Beanstalk I could knock up a fully automated build pipeline relatively simply. But lets leave that for another day. 😉

@Bradcomp

/cc @Bradcomp

davidchambers · 2017-06-09T07:59:20Z

scripts/eval.js

+
+module.exports = bot => {
+
+  bot.respond(/```(?:javascript|js)?$([\s\S]*)```/m, res => {


We could replace [\s\S] with [^], I think.

everything

f3fd96f

davidchambers commented Feb 18, 2017

View reviewed changes

svozza reviewed Feb 18, 2017

View reviewed changes

add circle.yml

04b8d60

Bradcomp reviewed Feb 18, 2017

View reviewed changes

circle: try ~/.npmrc

e3adbcd

Bradcomp reviewed Feb 18, 2017

View reviewed changes

davidchambers added 2 commits February 18, 2017 17:31

circle: remove ineffectual line

c7f2666

package.json: remove boilerplate

8c4299a

svozza approved these changes Feb 19, 2017

View reviewed changes

add dockerfile

ae0cd0f

davidchambers commented Feb 19, 2017

View reviewed changes

davidchambers added 14 commits February 19, 2017 16:37

Node v6.x.x

b5105c7

eval: make the language specifier optional

129118b

/cc @Bradcomp

move start-up command to package.json

abbcadd

prepend node_modules/.bin to PATH so coffee can be found

c8bb482

remove external-scripts.json

34069ff

remove makefile in favour of npm scripts

e5b77e5

update circle.yml

e3be2d3

dockerfile: combine RUN commands

d4714c1

scripts: use {foo, bar, baz} sugar

1c39c5c

scripts: use sanctuary-def

2155b51

scripts: use dependency version from package.json unless value is "*"

673398e

add Ramda

88a1f49

support console.log

bdd8eaa

sanctuary-style@0.5.x

e940287

davidchambers commented Jun 9, 2017

View reviewed changes

davidchambers added 3 commits October 27, 2017 23:37

circle: upgrade to CircleCI 2.0

188e517

sanctuary-style@1.0.x

76c19b3

fix package versions

21d704b

davidchambers added 12 commits May 29, 2018 11:46

sanctuary-style@2.0.x

b784072

sanctuary-identity@1.0.0

db75351

sanctuary@0.15.0

6f961bd

hubot@3.0.1

098d45a

remove stray semicolon

10e6b60

nodesource/node:10

31c46e5

add Fluture

37293c4

support console.error

de3b3b7

sanctuary@0.15.1

07ca507

sanctuary@1.0.0

c7d7b2e

sanctuary-style@3.0.x

239589c

sanctuary@1.1.0

68b33d3

davidchambers force-pushed the davidchambers/everything branch from 53ad407 to 6a7ddfb Compare April 27, 2019 21:04

sanctuary@2.0.0

856313f

davidchambers force-pushed the davidchambers/everything branch from 6a7ddfb to 856313f Compare April 27, 2019 21:16

davidchambers added 13 commits October 24, 2019 15:12

sanctuary-useless@1.1.0

e54022b

sanctuary@2.0.1

fd9b8f7

add FUNDING.yml

8c7ce10

circle: housekeeping

2513588

sanctuary-style@4.0.x

a339cd2

sanctuary@2.0.2

02d4eb3

sanctuary@3.0.0

23dafdb

fluture@12.2.0

e298b78

eval: use fluture-sanctuary-types

0527a55

eval: fix $Useless

f521a3a

sanctuary@3.1.0

83aaf70

eval: use S.show to show logged values

0da6e3e

circle: update Node version

6e49b8f

davidchambers force-pushed the davidchambers/everything branch from 154e99e to 6e49b8f Compare December 6, 2023 17:14

circle: update Node version

5b1f69a

		@@ -0,0 +1,14 @@
		ESLINT = node_modules/.bin/eslint --config node_modules/sanctuary-style/eslint-es3.json --env es3 --env node
		NPM = npm


		module.exports = bot => {

		bot.respond(/```(?:javascript\|js)?$([\s\S]*)```/m, res => {


		COPY . .

		ENTRYPOINT ["dumb-init", "bin/hubot"]

Conversation

davidchambers commented Feb 18, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

davidchambers commented Feb 18, 2017 •

edited

Loading