Open
Conversation
gyalla
force-pushed
the
output_particle_moments
branch
from
0294aa8 to
0371151
Compare
reuterb
reviewed
Apr 17, 2026
|
|
||
| const bool need_header = fileIsEmpty(filename); | ||
|
|
||
| std::ofstream out(filename, std::ios::app); |
Collaborator
There was a problem hiding this comment.
Does this mean append? Is the way this is structured mean that the same file can keep getting appended to if you don't delete it between sims?
reuterb
reviewed
Apr 17, 2026
| const std::string& file_prefix, | ||
| const int step, | ||
| const double time) | ||
| { |
Collaborator
There was a problem hiding this comment.
Can we put this in a free function a la DumpParticles.cpp? e.g.,
void dumpParticleMoments(const ParticleOperations& particle_operations,
const ParticleContainer& particles,
const std::string& filename_prefix,
const int step,
const double time)
{
auto & number_density = particle_operations.getNumberDensity(particles);
...
}
If not now, we should later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.