Skip to content

Fix touchmove preventDefault on non-cancelable events (#189) #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MusiikoDmytro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix touchmove preventDefault on non-cancelable events (#189) #193

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ci360.service.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,7 @@ class CI360Viewer {
// Normal single-finger drag for rotation
if (!this.isClicked || !event.touches || !event.touches[0]) return;
const { pageX, pageY } = event.touches[0];
event.preventDefault();
if (event.cancelable) event.preventDefault();

this.drag(pageX, pageY);
}
Expand Down
8 changes: 4 additions & 4 deletions src/utils/zoom/gestures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export class GestureRecognizer {

// Two-finger pinch start
if (event.touches.length === 2) {
event.preventDefault();
if (event.cancelable) event.preventDefault();
this.isPinching = true;
this.initialPinchDistance = this._getPinchDistance(event.touches[0], event.touches[1]);
this.pinchBaseZoom = typeof this.getZoom === 'function' ? this.getZoom() : 1;
Expand All @@ -77,7 +77,7 @@ export class GestureRecognizer {

if (dt < 300 && dx < 30 && dy < 30) {
// Double-tap detected
event.preventDefault();
if (event.cancelable) event.preventDefault();
event.stopPropagation(); // Prevent service touchStart from setting drag state
this.lastTapTime = 0;
if (typeof this.onDoubleTap === 'function') {
Expand All @@ -97,7 +97,7 @@ export class GestureRecognizer {

// Pinch zoom
if (this.isPinching && event.touches.length === 2) {
event.preventDefault();
if (event.cancelable) event.preventDefault();

const currentDistance = this._getPinchDistance(event.touches[0], event.touches[1]);
if (this.initialPinchDistance === 0) {
Expand All @@ -123,7 +123,7 @@ export class GestureRecognizer {
const currentZoom = typeof this.getZoom === 'function' ? this.getZoom() : 1;
if (currentZoom <= 1) return; // Let 360 rotation handle it

event.preventDefault();
if (event.cancelable) event.preventDefault();
const touch = event.touches[0];
const dx = touch.pageX - this.lastTouchX;
const dy = touch.pageY - this.lastTouchY;
Expand Down