Open
Conversation
added 24 commits
February 1, 2017 12:33
* make same as work
* add test to ensure we can re-use the compiler
* add normalizer to allow to compare internal hash keys
* require PHP7
* re-compile js
* exclude fixtures from code sniffer
Contributor
Author
|
Failing tests are related to the changed prefix for macros in Twig, ie: https://github.com/twigphp/Twig/blob/2.x/lib/Twig/TokenParser/From.php#L48 |
|
Someone plan to merge this PR into master ? |
Deal with removed `Environment::getCompiler()` method and the fact that we need a `Twig_Source` instance to compile
|
Hey @henrycatalinismith, is there anything we can do to push this along? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've set the composer alias to 2.0.x-dev as this is a major update. Not sure if this should go onto a 2.0 branch first and leave master for twig 1.x compatibility for now. Not sure how much more work is going into Twif 1.x...