Adding text labels to the examples for sanity#259
Open
AndrewRayCode wants to merge 1 commit intoschteppe:masterfrom
Open
Adding text labels to the examples for sanity#259AndrewRayCode wants to merge 1 commit intoschteppe:masterfrom
AndrewRayCode wants to merge 1 commit intoschteppe:masterfrom
Conversation
Adding text labels to the examples because a bunch of images of cubes and spheres are really hard to understand, especially when you want to quickly come to the homepage and find an example, but it's all images, and even the example pages themselves don't have labels :( Also updates CSS for minor styling alignment. However, it looks like something bad is going on here? The examples on master don't line up with the examples on the homepage. Why the discrepancy? It looks like the branch `gh-pages` has the up to date examples...(?) I can make the PR to that branch as well
AndrewRayCode
added a commit
to AndrewRayCode/cannon.js
that referenced
this pull request
Jan 21, 2016
See schteppe#259 for more detail. This ports that change to this branch which seems to have up to date examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding text labels to the examples because a bunch of images of cubes
and spheres are really hard to understand, especially when you want to
quickly come to the homepage and find an example, but it's all images,
and even the example pages themselves don't have labels :( Also updates
CSS for minor styling alignment.
However, it looks like something bad is going on here? The examples on
master don't line up with the examples on the homepage. Why the
discrepancy? It looks like the branch
gh-pageshas the up to dateexamples...(?) I can make the PR to that branch as well