Polyfill performance.now on global object#325
Open
brianchirls wants to merge 1 commit intoschteppe:masterfrom
Open
Polyfill performance.now on global object#325brianchirls wants to merge 1 commit intoschteppe:masterfrom
brianchirls wants to merge 1 commit intoschteppe:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If cannon.js is included in a script that runs in strict mode, the polyfill of
performancewill throw an error because it's undeclared. You can see this by adding "use strict" to World.js or the built script and running the web workers example in Mobile Safari (iOS only supportsperformancein the main thread, not in a worker) or running the unit test (node doesn't supportperformanceat all).In browsers, the polyfill needs to be set on
selfin either worker or the main thread. In node, it needs to be set onglobal.