Add prototype version of the system JWKS cache #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbockelm
force-pushed
the
system_jwks_cache
branch
from
0acec41 to
ae345dd
Compare
DrDaveD
reviewed
Dec 19, 2025
Contributor
DrDaveD
left a comment
DrDaveD
left a comment
There was a problem hiding this comment.
The code looks good to me, although it could use some more comments and some documentation somewhere saying that it is following the WLCG system JWKS cache standard.
It makes the most sense to me to implement fetch-jwks using the same code base, as a subpackage of scitokens-cpp (without inheriting the prefix).
djw8605
reviewed
Jan 15, 2026
| return oss.str(); | ||
| } | ||
|
|
||
| bool extract_json_objects(const std::string &content, |
Contributor
There was a problem hiding this comment.
I'm suprised that picojson doesn't have a function like "get me the next json object starting at this index", and "and next object starting at this index".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.