test: add missing tests for data_to_sqlite (#623)#676
test: add missing tests for data_to_sqlite (#623)#676keerthanakh89 wants to merge 0 commit intoscribe-org:mainfrom
Conversation
Thank you for the pull request! 💙🩵The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
|
@keerthanakh89, could you fix your email for GitHub as mentioned in my last comment in #675? Aside from this, the tests are failing and you've removed the license header from the file, so that check is also failing. Please let us know if you need support here :) |
|
Hi @andrewtavis! I've fixed the missing license header. |
|
Hi @keerthanakh89 👋 Could we ask you to run the tests locally? See the testing section of the contributing guide. The commands you should run in the project root are:
If all of those pass, you should be good to commit the change :) Also you'll need to have the dependencies installed with |
|
@keerthanakh89, please stop testing your code on CI. This is a waste of resources and is sending emails to all people who are watching the repository. Please see the local testing directions that I sent to you here. |
c26e8f1 to
37584c3
Compare
|
Hi! I’m going to pause work on this PR for now to better understand the project structure and testing requirements. I’ll come back with a cleaner approach. Thanks for the guidance! |
Fixes #623
Tests Added