Skip to content

test: add missing tests for data_to_sqlite (#623)#676

Closed
keerthanakh89 wants to merge 0 commit intoscribe-org:mainfrom
keerthanakh89:feature/add-missing-tests
Closed

test: add missing tests for data_to_sqlite (#623)#676
keerthanakh89 wants to merge 0 commit intoscribe-org:mainfrom
keerthanakh89:feature/add-missing-tests

Conversation

@keerthanakh89
Copy link
Copy Markdown
Contributor

Fixes #623

Tests Added

  • test_create_table_empty_columns
  • test_table_insert_empty_values
  • test_create_table_preserves_numbers
  • test_data_to_sqlite_multiple_languages
  • test_data_to_sqlite_specific_tables
  • test_data_to_sqlite_empty_language_list
  • test_translations_to_sqlite_empty_data
  • test_translations_to_sqlite_last_modified_missing
  • test_data_to_sqlite_relative_path
  • TestTableInsertSpecialCharacters class
  • test_data_to_sqlite_preserves_existing_data

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Copy Markdown
Member

@keerthanakh89, could you fix your email for GitHub as mentioned in my last comment in #675? Aside from this, the tests are failing and you've removed the license header from the file, so that check is also failing. Please let us know if you need support here :)

@keerthanakh89
Copy link
Copy Markdown
Contributor Author

Hi @andrewtavis! I've fixed the missing license header.
Could you please let me know which specific tests are
failing so I can fix them? Thank you for the support! 😊

@keerthanakh89 keerthanakh89 marked this pull request as draft March 31, 2026 10:11
@andrewtavis
Copy link
Copy Markdown
Member

Hi @keerthanakh89 👋 Could we ask you to run the tests locally? See the testing section of the contributing guide.

The commands you should run in the project root are:

  • uv run pytest . --cov=. --cov-report=term-missing --cov-fail-under=70 --cov-config=./pyproject.toml
  • uv run ruff format ./src
  • uv run ruff check ./src
  • uv run mypy ./src --config-file ./pyproject.toml

If all of those pass, you should be good to commit the change :) Also you'll need to have the dependencies installed with uv sync --frozen --all-extras, if you haven't done this already. And please install uv for package management.

@andrewtavis
Copy link
Copy Markdown
Member

@keerthanakh89, please stop testing your code on CI. This is a waste of resources and is sending emails to all people who are watching the repository. Please see the local testing directions that I sent to you here.

@keerthanakh89 keerthanakh89 force-pushed the feature/add-missing-tests branch from c26e8f1 to 37584c3 Compare March 31, 2026 14:11
@keerthanakh89 keerthanakh89 deleted the feature/add-missing-tests branch March 31, 2026 14:12
@keerthanakh89
Copy link
Copy Markdown
Contributor Author

Hi! I’m going to pause work on this PR for now to better understand the project structure and testing requirements. I’ll come back with a cleaner approach. Thanks for the guidance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Multiple assignees possible] Add missing tests to Scribe-Data

2 participants