Skip to content

fix - ty migration#682

Merged
andrewtavis merged 4 commits intoscribe-org:mainfrom
ashb155:fix/ty_migration
Apr 7, 2026
Merged

fix - ty migration#682
andrewtavis merged 4 commits intoscribe-org:mainfrom
ashb155:fix/ty_migration

Conversation

@ashb155
Copy link
Copy Markdown
Contributor

@ashb155 ashb155 commented Apr 4, 2026

Contributor checklist


Description

This PR migrates the project's static type checking from mypy to ty, Astral's new Rust-based type checker.

Files changed:

  • pyproject.toml — removed [tool.mypy] configuration and added [tool.ty.src] and [tool.ty.rules] sections. All rules are set to warn rather than error to establish a clean baseline without blocking CI, allowing existing type issues to be fixed incrementally in follow-up PRs. Currently scoped to src only — tests coverage can be added in a follow-up PR.
  • .github/workflows/ci_static_analysis.yml — replaced the mypy CI step with uvx ty check.
  • .pre-commit-config.yaml — added the astral-sh/ty pre-commit hook at revision 0.0.28.

Testing:
Ran uvx ty check locally — exits cleanly with 155 warnings and 0 errors across src

Related issue

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 4, 2026

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link
Copy Markdown
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Thanks for this, @ashb155! This is an amazing addition to the project 😊 I'll be in touch in the issue about what the next steps should be :) Looking forward to continuing to work with you on this!

@andrewtavis andrewtavis merged commit b061d9f into scribe-org:main Apr 7, 2026
6 checks passed
@ashb155 ashb155 deleted the fix/ty_migration branch April 8, 2026 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants