Merged
Conversation
Contributor
Thank you for the pull request! 💙🩵The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:
Note Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible. |
Contributor
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
andrewtavis
approved these changes
Apr 7, 2026
Member
andrewtavis
left a comment
There was a problem hiding this comment.
praise: Thanks for this, @ashb155! This is an amazing addition to the project 😊 I'll be in touch in the issue about what the next steps should be :) Looking forward to continuing to work with you on this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributor checklist
pytestcommand as directed in the testing section of the contributing guideDescription
This PR migrates the project's static type checking from
mypytoty, Astral's new Rust-based type checker.Files changed:
pyproject.toml— removed[tool.mypy]configuration and added[tool.ty.src]and[tool.ty.rules]sections. All rules are set towarnrather thanerrorto establish a clean baseline without blocking CI, allowing existing type issues to be fixed incrementally in follow-up PRs. Currently scoped tosrconly —testscoverage can be added in a follow-up PR..github/workflows/ci_static_analysis.yml— replaced themypyCI step withuvx ty check..pre-commit-config.yaml— added theastral-sh/typre-commit hook at revision0.0.28.Testing:
Ran
uvx ty checklocally — exits cleanly with 155 warnings and 0 errors acrosssrcRelated issue