Skip to content

invalid-parameter-default fix#685

Open
ashb155 wants to merge 3 commits intoscribe-org:mainfrom
ashb155:ty_fixes
Open

invalid-parameter-default fix#685
ashb155 wants to merge 3 commits intoscribe-org:mainfrom
ashb155:ty_fixes

Conversation

@ashb155
Copy link
Copy Markdown
Contributor

@ashb155 ashb155 commented Apr 14, 2026

Contributor checklist


Description

Fixed invalid-parameter-default warnings by updating for optional parameters across 9 files:

  • cli/contracts/filter.py
  • cli/convert.py
  • cli/get.py
  • cli/list.py
  • cli/total.py
  • unicode/generate_emoji_keywords.py
  • wikidata/parse_dump.py
  • wikidata/query_data.py
  • wikidata/wikidata_utils.py

Verified with uvx ty check — no remaining invalid-parameter-default warnings.

Related issue

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for the pull request! 💙🩵

The Scribe-Data team will do our best to address your contribution as soon as we can. The following are some important points:

  • Those interested in developing their skills and expanding their role in the community should read the mentorship and growth section of the contribution guide
  • If you're not already a member of our public Matrix community, please consider joining!
    • We'd suggest that you use the Element client as well as Element X for a mobile app
    • Join the General and Data rooms once you're in
  • Also consider attending our bi-weekly Saturday developer syncs!
    • Details are shared in the General room on Matrix each Wednesday before the sync
    • It would be great to meet you 😊

Note

Scribe uses Conventional Comments in reviews to make sure that communication is as clear as possible.

@github-actions
Copy link
Copy Markdown
Contributor

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • Tests for changes have been written and the pytest, linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@ashb155
Copy link
Copy Markdown
Contributor Author

ashb155 commented Apr 14, 2026

hi @andrewtavis , I guess checks are failing since I missed downgrading 'not-iterable' ty errors to 'warn' in my previous migration-related PR, it is getting flagged in the checks by default, could you please have a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant