Rework implementation of boosting for channel-slicing slimmable WaveNet, update model export version to 0.7.0.#644
Merged
sdatkinson merged 4 commits intomainfrom Mar 13, 2026
Merged
Conversation
- SlimmableConv1dBase._get_slim_indices derives i_in, i_out from ratio and allowed channel lengths (configured in each subclass __init__) - Remove redundant _get_slim_indices overrides from RechannelIn, LayerConv, InputMixer, Layer1x1, HeadRechannel - Add _is_first default to base; remove _output_paired, abc import - Head1x1 retains override (NotImplementedError) Made-with: Cursor
Owner
Author
|
Golly, the graceful shutdown tests are flaky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code feels cleaner. I could've sworn that I saw nonzero grads where they shouldn't have been as well, but apparently the reworked test still passes on
main, so 🤷🏻