Skip to content

chore: update FIR boundaries to null#1648

Open
fredclausen wants to merge 1 commit intomainfrom
update-fir-boundaries-null
Open

chore: update FIR boundaries to null#1648
fredclausen wants to merge 1 commit intomainfrom
update-fir-boundaries-null

Conversation

@fredclausen
Copy link
Member

FIR Boundary Update

This PR updates the VATSpy FIR boundary GeoJSON data to version null.

Changes

  • ✅ Updated FIRBoundaries.geojson from vatspy-data-project release
  • ✅ Updated version in ATTRIBUTIONS.md

Source

Testing Checklist

  • FIR boundaries render correctly on the live map
  • No console errors related to GeoJSON loading
  • Boundary polygons appear at expected locations
  • Hover popups show the correct FIR identifier and division
  • Mobile and desktop views both work

This PR was automatically created by the update-fir-boundaries GitHub Action.

Copilot AI review requested due to automatic review settings March 9, 2026 05:16
@fredclausen fredclausen added automated dependencies Pull requests that update a dependency file labels Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the VATSpy FIR boundary dataset used by the React frontend’s live map overlays, along with its third‑party attribution metadata.

Changes:

  • Updates the FIR boundary GeoJSON asset (FIRBoundaries.geojson).
  • Updates the recorded VATSpy dataset version in ATTRIBUTIONS.md.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.

File Description
acarshub-react/src/assets/geojson/FIRBoundaries.geojson FIR boundary GeoJSON asset content update used by the live map overlay loader.
acarshub-react/ATTRIBUTIONS.md Updates the VATSpy dataset version recorded for third‑party attribution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIRBoundaries.geojson currently contains the literal text Not Found instead of valid GeoJSON. This will fail to load/parse at runtime (and likely indicates the update job downloaded a 404 response). Replace this file with the actual VATSpy FIR boundary FeatureCollection from a real release/tag.

Suggested change
{
"type": "FeatureCollection",
"name": "VATSpy FIR Boundaries",
"features": []
}

Copilot uses AI. Check for mistakes.
- **Usage**: FIR (Flight Information Region) boundary overlays on the live map
- **Assets**: `src/assets/geojson/FIRBoundaries.geojson`
- **Version**: v2602.1
- **Version**: null
Copy link

Copilot AI Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The attribution version is set to null, which isn't a meaningful dataset version and likely reflects a failed/empty release tag. Please set this to the actual VATSpy data project release/tag used to generate FIRBoundaries.geojson (e.g., the AIRAC-based version) so attributions remain accurate.

Suggested change
- **Version**: null
- **Version**: unknown (VATSpy release/AIRAC version not recorded; future updates must record the exact tag used)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automated dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants