add Curl support via configuration page#114
Open
Mickael-Martin wants to merge 4 commits intosebsauvage:masterfrom
Mickael-Martin:master
Open
add Curl support via configuration page#114Mickael-Martin wants to merge 4 commits intosebsauvage:masterfrom Mickael-Martin:master
Mickael-Martin wants to merge 4 commits intosebsauvage:masterfrom
Mickael-Martin:master
Conversation
|
Pourrais-tu documenter l'objectif de tes modifications ? Je crois comprendre à partir du diff' que tu veux utiliser Curl pour récupérer les info' d'un lien depuis une page HTTPS, mais je n'en suis pas sûr. Il serait donc pratique que tu documentes dans le README l'utilisation de l'option Curl, éventuellement les pré-requis pour que ça fonctionne, etc. Tu feras attention aussi, je crois que l'indentation de ton code n'est pas uniforme avec le reste (tabulations à la place d'espaces, ou trucs comme ça) |
pikzen
pushed a commit
to pikzen/Shaarli
that referenced
this pull request
Feb 18, 2015
redirect to previous search (if any) when deleting a link
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Il y a peut-être quelques trucs à modifier, mais la grosse partie de la gestion du Curl est là.
Maybe some thinks to modify...