Conversation
There was a problem hiding this comment.
Please update this line again, as now it doesn't only mean that the username and password are correct, but can mean that the LDAP login is valid. Suggested change:
"Username/password combination is valid, or LDAP authentication was successful"
|
Hi meutel, thanks for the pull request. Looking through your pull request, I have made a couple of comments inline (in the Files Changed tab). This functionality requires the presence of multiple configuration values. To prevent future issues being logged of the type "LDAP doesn't work" that would be due to the user not reading the source code closely enough (which we can't really expect) and missing one of the parameters, I suggest you add these parameters in the GUI configuration part. If you need an example, look at the changes made to Thanks for your work on Shaarli. |
|
Hi there ! Sorry to dig up this old pull request, but has any work been done to make this pull request on the community's repository (I could not find it)? Would any of you know if this PR could be taken as a base or if the codebase changed too much and this PR's code is now stale? Thanks in advance, I think it would be really nice to have this (in particular with the YunoHost package of Shaarli if you know YNH). |
Adds simple LDAP authentification. Uses additional config:
auth_backend: use "LDAP" to active LDAP authentification
ldaphost: LDAP server hostname
ldapport: LDAP server port
ldaprdntpl: user RDN template (%login% replaced by actual login), example: uid=%login%,ou=people,dc=example,dc=org