feat(browser): support for nonce in some loadScript calls#1302
Open
Grohden wants to merge 4 commits intosegmentio:masterfrom
Open
feat(browser): support for nonce in some loadScript calls#1302Grohden wants to merge 4 commits intosegmentio:masterfrom
Grohden wants to merge 4 commits intosegmentio:masterfrom
Conversation
🦋 Changeset detectedLatest commit: 9818302 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dapx
approved these changes
May 20, 2025
arielsilveira
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #377
I'm adding the support for calling
analytics.load(settings, { nonce })and carrying that nonce to most places where segment injects scripts. I've also fixed a lil typo.Note: this does not cover all places AFAIK, there's some polyfills somewhere which might need attention. I'm not focusing this PR on them.
Note 2: I've tested this here locally in a nextjs project
yarn changeset. Read about changesets here).