Regenerate semgrep_output_v1.py with atdpy 3.0.1 #426
Merged
+2,555
−3,899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backwards compatibility summary: |
Member
Author
|
Waiting for the opam release of atdpy 3.0.0 that's in progress at ocaml/opam-repository#29054 |
mjambon
changed the title
mjambon
force-pushed
the
martin/atdpy-doc-demo
branch
from
cd5abe7 to
0bbbbf5
Compare
nmote
approved these changes
Dec 19, 2025
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Dec 22, 2025
In order to get doc comments as Python docstrings in the Python code generated by atdpy in semgrep-interfaces, we need atdpy >= 3.0.0 which requires upgrading the other atd tools, requiring an upgrade to yojson 3. This PR uses semgrep/semgrep-interfaces#426 which regenerates the Python code with the changes we care about + the OCaml code with the changes needed for compatibility with yojson 3. Test plan: CI checks synced from Pro 773c2c6601ff5a7a37704591a5d73e3d105b80ee
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Dec 22, 2025
In order to get doc comments as Python docstrings in the Python code generated by atdpy in semgrep-interfaces, we need atdpy >= 3.0.0 which requires upgrading the other atd tools, requiring an upgrade to yojson 3. This PR uses semgrep/semgrep-interfaces#426 which regenerates the Python code with the changes we care about + the OCaml code with the changes needed for compatibility with yojson 3. Test plan: CI checks synced from Pro 773c2c6601ff5a7a37704591a5d73e3d105b80ee
semgrep-ci bot
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Dec 22, 2025
In order to get doc comments as Python docstrings in the Python code generated by atdpy in semgrep-interfaces, we need atdpy >= 3.0.0 which requires upgrading the other atd tools, requiring an upgrade to yojson 3. This PR uses semgrep/semgrep-interfaces#426 which regenerates the Python code with the changes we care about + the OCaml code with the changes needed for compatibility with yojson 3. Test plan: CI checks synced from Pro 773c2c6601ff5a7a37704591a5d73e3d105b80ee
yosefAlsuhaibani
pushed a commit
to semgrep/semgrep
that referenced
this pull request
Dec 22, 2025
In order to get doc comments as Python docstrings in the Python code generated by atdpy in semgrep-interfaces, we need atdpy >= 3.0.0 which requires upgrading the other atd tools, requiring an upgrade to yojson 3. This PR uses semgrep/semgrep-interfaces#426 which regenerates the Python code with the changes we care about + the OCaml code with the changes needed for compatibility with yojson 3. Test plan: CI checks synced from Pro 773c2c6601ff5a7a37704591a5d73e3d105b80ee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
atdpy now honors
<doc text="...">annotations like atdgen and turns them into Python docstrings.make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged