-
Notifications
You must be signed in to change notification settings - Fork 13
chore: add dune-project file
#428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Backwards compatibility summary: |
kopecs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
imo if we do this we should consider generating the generated code by rule in dune, rather than checking it in (current way may still be better given it eliminates a dependency on the generator(s) if you're not changing this, but we should think about it)
This file is needed in order to pin
semgrep-interfacesas an opam package by git has as opposed to by path (i.egit+https//...#<sha>vs./cli/interfaces/semgrep_interfaces/)make setup && maketo update the generated code after editing a.atdfile (TODO: have a CI check)For example, the Semgrep backend need to still be able to consume data
generated by Semgrep 1.50.0.
See https://atd.readthedocs.io/en/latest/atdgen-tutorial.html#smooth-protocol-upgrades
Note that the types related to the semgrep-core JSON output or the
semgrep-core RPC do not need to be backward compatible!
semgrep-proprietaryare approved and ready to merge once this PR is merged