Fix unhandled ArithmeticException in div_zero button click listener - #250
Open
sentry[bot] wants to merge 1 commit into
Open
Fix unhandled ArithmeticException in div_zero button click listener#250sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Wrap the hardcoded 5 / 0 division in a try/catch block and capture the ArithmeticException via Sentry instead of letting it crash the app. Fixes [ANDROID-M0](https://demo.sentry.io/issues/7653043052/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 886 +3
Branches 67 67
=====================================
- Misses 883 886 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
div_zerobutton contained a hardcodedint t = 5 / 0expression that unconditionally threw an unhandledArithmeticException, crashing the app on every tap.Fix
Wrapped the division in a
try/catch (ArithmeticException e)block and capture the exception viaSentry.captureException(e), making it a handled error instead of a fatal crash.Changes
MainActivity.javaline 53: wrap5 / 0in try/catch and capture exception with SentryFixes ANDROID-M0