Fix NegativeArraySizeException in MainActivity negative_index handler - #256
Open
sentry[bot] wants to merge 1 commit into
Open
Fix NegativeArraySizeException in MainActivity negative_index handler#256sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
The onClick handler for the 'negative_index' button allocated an array with a hardcoded negative size (new int[-5]), which always throws NegativeArraySizeException at runtime and crashes the app. Clamp the requested size to a non-negative value before allocating and report the invalid size to Sentry as a handled warning instead of crashing. Fixes [ANDROID-KZ](https://demo.sentry.io/issues/7653041035/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 888 +5
Branches 67 68 +1
=====================================
- Misses 883 888 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ANDROID-KZ
Root cause
The
onClickhandler for thenegative_indexbutton inMainActivityallocated an array with a hardcoded negative size:Java does not permit negative array sizes, so this line always throws
NegativeArraySizeException: -5and crashes the app as soon as the button is tapped (MainActivity.java:61).Fix
The requested size is now clamped to a non-negative value before the allocation, and the invalid input is reported to Sentry as a handled warning instead of taking down the process:
Verification
Since the Android SDK/NDK is not available in this environment, the handler was verified by compiling
MainActivityagainst the real Sentry (8.51.0) and Gson jars plus minimal stubs for the Android framework classes it uses, then invoking the registerednegative_indexclick listener:java.lang.NegativeArraySizeException: -5thrown from the lambda (reproduces the reported crash).Sentry.captureMessage(String, SentryLevel)was confirmed to exist in the SDK version used by the project (javapagainstsentry-8.51.0.jar).