Fix ArrayIndexOutOfBoundsException in createTempFileSecure - #257
Draft
cursor[bot] wants to merge 1 commit into
Draft
Fix ArrayIndexOutOfBoundsException in createTempFileSecure#257cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Change boundary check from 'index > cacheFiles.length' to 'index >= cacheFiles.length' to prevent accessing array at index equal to length. Arrays are zero-indexed (valid range 0..length-1), so index == length is out of bounds. Fixes [ANDROID-JG](https://demo.sentry.io/issues/7601217253/)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 883 883
Branches 67 67
=====================================
Misses 883 883 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed an off-by-one error in
MyBaseActivity.createTempFileSecurethat caused anArrayIndexOutOfBoundsExceptionwhen the random index generator produced a value equal to the array length.Changes
index > cacheFiles.lengthtoindex >= cacheFiles.lengthon line 163Root Cause
The condition
index > cacheFiles.lengthallowedindexto equalcacheFiles.length, which is invalid for array access. Arrays are zero-indexed with valid range 0..length-1, soindex == lengthis out of bounds and causes an exception when accessingcacheFiles[index].Fixes ANDROID-JG