Upgrade C++ linting to use modern cpplint tooling#227
Open
lovell wants to merge 2 commits intoserialport:mainfrom
Open
Upgrade C++ linting to use modern cpplint tooling#227lovell wants to merge 2 commits intoserialport:mainfrom
lovell wants to merge 2 commits intoserialport:mainfrom
Conversation
Ensures compliance with a couple of important new rules: - build/include_what_you_use - runtime/references Adds a standard cpplint config with list of ignored rules, mostly whitespace-related. Getting these to pass is left as a future exerise.
Windows 2019 reached EOL on 2025-06-30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches from cc to @cpplint/cli (I maintain both, but the former will be deprecated/archived soon).
Ensures compliance with a couple of important new rules:
build/include_what_you_useruntime/referencesAdds a standard
CPPLINT.cfgconfiguration file with a list of ignored rules, mostly whitespace-related. Getting these to pass is left as a future exerise.Finally, in a separate commit, upgrades Windows CI to a supported version (the windows-2019 runner reached EOL on 2025-06-30).