Skip to content

fix: register poller listeners before polling - #240

Open
Azq2 wants to merge 1 commit into
serialport:mainfrom
siemens-mobile-hacks:fix/poller-listener-order
Open

fix: register poller listeners before polling#240
Azq2 wants to merge 1 commit into
serialport:mainfrom
siemens-mobile-hacks:fix/poller-listener-order

Conversation

@Azq2

@Azq2 Azq2 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Possible race condition

@DragonWork

Copy link
Copy Markdown

From checking the native path, polling only asks the event loop to notify us later, so the listener is already attached when the callback arrives. I could not reproduce any race conditions with 60-100k events. The MakeCallback fix seems sufficient for the stall, unless I’m missing another case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants