Fix hold_keys dropping duplicate keys in + syntax (#1347) - #1351
Open
arturomaciaas wants to merge 1 commit into
Open
Fix hold_keys dropping duplicate keys in + syntax (#1347)#1351arturomaciaas wants to merge 1 commit into
arturomaciaas wants to merge 1 commit into
Conversation
arturomaciaas
force-pushed
the
fix/hold-keys-duplicate-symbols
branch
from
August 26, 2026 23:54
3b6b926 to
b833c80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1347
Problem
When using the + syntax with repeated keys (e.g., KEY_4+KEY_3+KEY_5+KEY_5+KEY_9), duplicate keys were silently dropped because pressing an already-held key is a no-op at the kernel level.
Solution
The fix releases a key before re-pressing it when a duplicate is encountered in hold_keys, so that sequences like KEY_5+KEY_5 properly output both keystrokes.
What was changed
Before: KEY_4+KEY_3+KEY_5+KEY_5+KEY_9+KEY_4+KEY_1+KEY_2+KEY_8+KEY_5 = 4359128
After: KEY_4+KEY_3+KEY_5+KEY_5+KEY_9+KEY_4+KEY_1+KEY_2+KEY_8+KEY_5 = 4355941285