Skip to content

add fema analyses in#740

Open
oscarsyu wants to merge 1 commit intodevelopfrom
add_published_analyses
Open

add fema analyses in#740
oscarsyu wants to merge 1 commit intodevelopfrom
add_published_analyses

Conversation

@oscarsyu
Copy link
Copy Markdown
Collaborator

Description

add a short description

reference to relevant issue

Type of changes

  • ( ) Bugfix
  • ( ) Chore
  • ( ) New Feature

Testing

  • ( ) I added automated tests
  • ( ) I think tests are unnecessary

How to test

testing description here: i.e. run app, go to x page, see that it does y

Clean commits

  • ( ) I plan to Squash and Merge
  • ( ) My commit history is clean¹
    ¹ described here

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 23, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
datasci-earthquake Ready Ready Preview Comment Nov 23, 2025 8:49pm

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @oscarsyu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation for exploratory data analyses by adding direct links to published FEMA-related risk score analyses. It also includes a minor configuration update for VS Code to streamline GitHub Pull Request management by ignoring the develop branch.

Highlights

  • FEMA Analysis Documentation: The datasets-eda/README.md file has been updated to include a new section "List of Published Analyses" with direct links to FEMA Risk Scores and Risk Scores by Neighborhood.
  • VS Code Configuration Update: The .vscode/settings.json file has been modified to add the develop branch to the list of githubPullRequests.ignoredPullRequestBranches.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new exploratory data analyses for FEMA's National Risk Index and USGS fault data. It also updates the datasets-eda/README.md to link to the published HTML versions of these analyses.

My review focuses on the README.md file, where I've found a few opportunities for improvement:

  • A redundant heading and some extra whitespace can be removed for better formatting.
  • One of the new links appears to point to a file that is not included in this pull request, which would result in a broken link.

Additionally, I've reviewed the new R Markdown files provided for context. In datasets-eda/fema_nri/eda_fema_nri.Rmd, there's a potential for a division-by-zero error on line 152. It would be beneficial to add a safeguard against this.

Finally, please consider filling out the pull request description. Providing details on the changes and testing helps reviewers understand the context and purpose of the PR.


## List of Published Analyses:
* [FEMA Risk Scores](https://pmarchand1.github.io/sf-earthquake-data/eda_fema_nri.html)
* [Risk Scores by Neighborhood](https://pmarchand1.github.io/sf-earthquake-data/nri_neighborhoods.html)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This link points to nri_neighborhoods.html, but the source file that generates this HTML (e.g., an .Rmd file) appears to be missing from the pull request. This will likely result in a broken link. Please ensure the source file for this analysis is included in the repository.

Comment on lines +1 to +2
## README

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The ## README heading is redundant as the file is already named README.md. Removing this heading and the subsequent blank line will make the document cleaner and more direct.


The analyses are in RMarkdown and HTML format.


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There's an extra blank line here. Typically, a single blank line is sufficient to separate sections in Markdown. Removing this extra line will improve formatting consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant