Skip to content

testing - remove etl from ci#807

Open
bees-dont-have-knees wants to merge 50 commits intodevelopfrom
knees_remove_etl_from_ci
Open

testing - remove etl from ci#807
bees-dont-have-knees wants to merge 50 commits intodevelopfrom
knees_remove_etl_from_ci

Conversation

@bees-dont-have-knees
Copy link
Copy Markdown
Collaborator

Description

remove etl from ci (will flesh out details)

Type of changes

  • ( ) Bugfix
  • (x) Chore
  • ( ) New Feature

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 9, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
datasci-earthquake Ready Ready Preview, Comment Feb 15, 2026 3:01pm

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @bees-dont-have-knees, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to remove ETL (Extract, Transform, Load) processes from the continuous integration (CI) pipeline, categorized as a chore. The specific code change included is a temporary debugging print statement in backend/database/session.py, intended to help verify environment settings during the CI process. The primary goal is to streamline the CI by eliminating ETL-related steps.

Highlights

  • CI Configuration Debugging: A debugging print statement has been introduced in backend/database/session.py within the _get_database_url function. This statement logs the current environment setting when the application is running in 'local' or 'ci' mode, likely to assist in verifying environment configurations related to the broader CI changes.
Changelog
  • backend/database/session.py
    • Added a print statement to log the settings.environment value when determining the database URL for 'local' or 'ci' environments within the _get_database_url function.
Activity
  • The pull request was initiated by bees-dont-have-knees with the stated purpose of removing ETL from the CI pipeline.
  • A debugging print statement was added to backend/database/session.py, likely as a temporary measure to aid in testing or verifying environment configurations related to the CI changes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a single print statement, likely for debugging purposes. My review highlights that this line should be removed as it's not suitable for production code and, more critically, it introduces a mix of tabs and spaces for indentation which can cause runtime errors in Python.

def _get_database_url() -> str:
match settings.environment:
case "local" | "ci":
print(f'the env... = {settings.environment}')
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This print statement appears to be leftover debugging code and should be removed before merging. It adds unnecessary noise to the application's output.

Critically, this line mixes tabs and spaces for indentation. This is a violation of PEP 8 and can lead to a TabError in Python, which would break the application. The rest of the file consistently uses spaces for indentation, so this line should be removed to maintain consistency and prevent potential runtime errors.

References
  1. PEP 8, the style guide for Python code, strongly advises against mixing tabs and spaces for indentation. The standard convention is to use 4 spaces per indentation level to avoid ambiguity and ensure consistency. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant