Open
Conversation
odo-sfct
force-pushed
the
ow/track-device-info
branch
from
63b0cc8 to
d6a59cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is through a fork; I actually don't have write access to this repo.
This patch just gets the ball rolling for tracking device.
For now, if we just need OS version and device type (iOS or Android) the
Platformbuilt-in library provided by react native is enough.If we want the device model, we'll need to get react-native-info which can be tackled by someone else.
Backend /v2/ routes are made to follow RESTful route patterns; POST for create, PATCH for partial updates.
The update route in the backend should take into account that a user can have multiple devices (device_id), so the update should save these fields appropriately.
Asana: https://app.asana.com/0/1201140011812889/1207165983004193/f