fix(cli): keep nested at-rules scoped to their selector when merging CSS#11089
Open
abhijeet117 wants to merge 1 commit into
Open
fix(cli): keep nested at-rules scoped to their selector when merging CSS#11089abhijeet117 wants to merge 1 commit into
abhijeet117 wants to merge 1 commit into
Conversation
Nested at-rules such as @media inside a selector were attached to the parent at-rule instead of the selector, which hoisted their declarations up one level and produced invalid css. Fixes shadcn-ui#10375
Contributor
|
@abhijeet117 is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Can you sign the commits please? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a registry item's css nests an at-rule such as @media inside a selector, the CLI placed it under the parent at-rule instead of the selector. This happened because processRule recursed with the parent container for nested objects, so the at-rule and its declarations were hoisted up one level and produced invalid css. The fix keeps nested at-rules scoped to the current rule so their declarations stay inside the correct selector. Includes a regression test.
Fixes #10375