SG-36195 Remove Python<3.9 and SGD<=1.7 compat#157
Draft
julien-lang wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
Removes legacy compatibility shims for Python < 3.9 and tk-desktop <= 1.7, simplifying the bootstrap/run paths and renaming the now-only error class EngineNotCompatibleWithDesktop16 to EngineNotCompatibleWithDesktop. The Qt-compatibility version threshold for raising this error is bumped from v1.6.1 to v1.8.0, and the error message text is being reworded.
Changes:
- Drop Python 3 / pre-0.19 core
SyntaxError/CookieandTypeError/qRegisterResourceDatarecovery branches instartup.py. - Rename
EngineNotCompatibleWithDesktop16→EngineNotCompatibleWithDesktopand update its message/URL (currently with placeholder text). - Raise the compatibility threshold in
__ensure_engine_compatible_with_qt_versionfromv1.6.1tov1.8.0.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| python/shotgun_desktop/startup.py | Removes obsolete Py3/old-core fallback exception handlers, renames the exception used, and bumps the compatibility version check to v1.8.0. |
| python/shotgun_desktop/errors.py | Renames EngineNotCompatibleWithDesktop16 to EngineNotCompatibleWithDesktop and rewrites its user-facing message and link (contains TODO/placeholder content). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+142
to
+147
| "Your version of tk-desktop is not compatible with this FlowPT Desktop {}.\n" | ||
| "\n" | ||
| "Please upgrade your site configuration's tk-desktop to v2.5.9+ or " | ||
| "download PTR desktop app 1.5.9 or earlier <a href='{}'>here</a>".format( | ||
| "Please upgrade your site configuration's tk-desktop to v2.5.9+ or " ## TODO change | ||
| "download FlowPT desktop v1.XXX5.9 or earlier <a href='{}'>here</a>".format( # OK but wrong info since unsupported.... | ||
| app_version, | ||
| "https://community.shotgridsoftware.com/t/a-new-version-of-shotgrid-desktop-has-been-released/13877/99999", | ||
| "https://community.shotgridsoftware.com/t/13877", |
| EngineNotCompatibleWithDesktop16, | ||
| EngineNotCompatibleWithDesktop, | ||
| UpgradeCoreError, | ||
| UpgradeCorePython3Error, |
| @@ -663,8 +640,8 @@ def __ensure_engine_compatible_with_qt_version(engine, app_version): | |||
| return | |||
|
|
|||
| # Versions of desktop older than v2.5.0 have issues with desktop 1.6.1+, so raise an error. | |||
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 10.30% 10.50% +0.19%
==========================================
Files 13 13
Lines 582 571 -11
==========================================
Hits 60 60
+ Misses 522 511 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.