create a new function to combine getSVG and getMetrics - #57
Open
omkelderman wants to merge 2 commits into
Open
Conversation
Author
|
hmm, I actually now just realized that the same can be done for This should be able to be optimised even more |
|
Great idea @omkelderman. I would certainly benefit from having this option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a need to get both the metrics and the SVG string at the same time. Now I could have just called
getSVGandgetMetricsin my code and be done with it, but I noticed thatgetSVGactually usedgetMetricsinternally so then it would be called twice.So I thought why not expose a function to get them both at the same time in an efficient manner.
This change is entirely backwards compatible.