fix: Web search with quotation marks causes 400 error. (#210)#211
Open
ssnailed wants to merge 1 commit intosigoden:mainfrom
Open
fix: Web search with quotation marks causes 400 error. (#210)#211ssnailed wants to merge 1 commit intosigoden:mainfrom
ssnailed wants to merge 1 commit intosigoden:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a reimplementation of the web_search_perplexity and web_search_tavily tools using jq to generate the json body POSTed by
curl.Since
jqis already a requirement of this script this is an elegant solution.This was tested with claude sonnet 4:
temp) search this: test "test" 0 I'll search for 'test "test"' using web search to find the most relevant results. Call web_search {"query":"test \"test\""} The search for 'test "test"' returned a general definition. The term "test" refers to a means of evaluating or examining something. It can be used in various contexts such as: - **Assessment**: Educational tests or evaluations - **Experiment**: Scientific tests or trials - **Software testing**: Quality assurance and debugging processes - **Speed tests**: Performance measurements - **General evaluation**: Any form of examination or trial Is there a specific type of test or context you're looking for more information about? I can search for more specific details if you let me know what particular aspect of testing interests you. temp) .info model claude:claude-sonnet-4-20250514 temperature null top_p null use_tools web max_output_tokens 8192 (current model) save_session null compress_threshold 4000 rag_reranker_model jina:jina-reranker-v2-base-multilingual rag_top_k 5 dry_run false function_calling true stream true save false